• Ng Zhi An's avatar
    [wasm-simd][liftoff] Fix i64x2.mul codegen bug · f7ac5a29
    Ng Zhi An authored
    When dst != lhs, we moved lhs to dst, but dst can be == rhs, so we would
    overwrite rhs, and end up comparing lhs with itself, always returning
    false. We handle the different aliasing cases in the macro-assembler
    function I64x2GtS, to simplify the checks in Liftoff a little bit.
    TurboFan does not need to change as it will require dst == lhs when AVX
    is not supported.
    
    Bug: v8:12237
    Change-Id: Icefa6eb79083c003e93dbbd11ccc419aae4b15d3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3169312Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76945}
    f7ac5a29
Name
Last commit
Last update
..
benchmarks Loading commit data...
bigint Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...