• Marja Hölttä's avatar
    [parser] Skipping inner funcs: Fix hoisting. · f6f5bafe
    Marja Hölttä authored
    The catch variable is a special VAR-mode variable which is not in a declaration
    scope. Normally creating such a variable is not possible with DeclareVariable,
    but Parser bypasses it by calling DeclareLocal directly (which doesn't have the
    hoisting check).
    
    PreParser used to cut corners and declare the catch variable as a LET-mode
    variable to prevent hoisting.
    
    But since LET and VAR variables behave differently when deciding whether they
    block sloppy block function hoisting, that approach doesn't fly.
    
    BUG=v8:5516,chromium:771474
    
    Change-Id: Ic6f5f4996416c9fa59132725c8b0b6b570c72f48
    Reviewed-on: https://chromium-review.googlesource.com/700634
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48308}
    f6f5bafe
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...