• Leszek Swirski's avatar
    [scopes] Push sloppy eval check through eval scopes · f6057ff1
    Leszek Swirski authored
    Sloppy eval extends the outer declaration scope's context. This is also
    true for sloppy eval inside of other sloppy evals -- the outer declaration
    scope's context is extended rather than the outer sloppy eval's
    declaration scope. However, we consider eval scopes to also be declaration
    scopes, for the purposes of strict eval and caching lookup variables. So,
    we need to make sure that we skip through sloppy eval scopes when marking
    a scope as calls_sloppy_eval.
    
    In fact, we implement this rather as never marking sloppy eval scopes as
    calls_sloppy_eval, under the assumption that the parent scope will already
    have been marked calls_sloppy_eval by the outer eval.
    
    As a drive-by, fix a TODO to move this logic from calls_sloppy_eval() to
    RecordEvalCall(), rename the variable to something more meaningful, and
    make Snapshotting to use a new calls_eval bit on Scope.
    
    Bug: chromium:996751
    Change-Id: I27ccc7ef429a7ce60b3bb02bf64a3820ae4a2c36
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1773247
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63455}
    f6057ff1
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...