• machenbach's avatar
    Revert of [Interpreter] Adds support to fetch return value on break at return.... · 25d2b247
    machenbach authored
    Revert of [Interpreter] Adds support to fetch return value on break at return. (patchset #9 id:160001 of https://codereview.chromium.org/1818873003/ )
    
    Reason for revert:
    [Sheriff] Seems to break nosnap debug:
    https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/6019
    
    Original issue's description:
    > [Interpreter] Adds support to fetch return value on break at return.
    >
    > Debugger fetches the return value of a function when we break at return.
    > Interpreter holds the return value in accumulator. This is not stored in a
    > specified location on stack and hence it is not possible to look it up from
    > stack similar to full-codegen or optimized frames. This cl adds support to
    > store the value of accumulator on debug breaks. The value of accumulator is
    > passed to the runtime function and is then stored in thread local data.
    >
    > Also changes full-codegen implementation to match that of ignition.
    > The return value from full-codegen is also stored in thread local data.
    > The return value is fetched directly thread local data instead of
    > finding it by iterating over frames.
    >
    > BUG=v8:4280, v8:4690
    > LOG=N
    >
    > Committed: https://crrev.com/fb65527b75754bcf3b173f16f5d0b04a1c6d9b99
    > Cr-Commit-Position: refs/heads/master@{#35060}
    
    TBR=rmcilroy@chromium.org,yangguo@chromium.org,weiliang.lin@intel.com,balazs.kilvady@imgtec.com,jyan@ca.ibm.com,mythria@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:4280, v8:4690
    
    Review URL: https://codereview.chromium.org/1834733002
    
    Cr-Commit-Position: refs/heads/master@{#35065}
    25d2b247
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
x87 Loading commit data...
OWNERS Loading commit data...
debug-evaluate.cc Loading commit data...
debug-evaluate.h Loading commit data...
debug-frames.cc Loading commit data...
debug-frames.h Loading commit data...
debug-scopes.cc Loading commit data...
debug-scopes.h Loading commit data...
debug.cc Loading commit data...
debug.h Loading commit data...
debug.js Loading commit data...
liveedit.cc Loading commit data...
liveedit.h Loading commit data...
liveedit.js Loading commit data...
mirrors.js Loading commit data...