• cbruni's avatar
    [keys] Trigger [[getOwnPropertyDescriptor]] trap on proxies for Object.keys · f4f06c50
    cbruni authored
    This CL fixes a long-standing bug with Object.keys where the enumerability
    check was omitted if the [ownKeys] trap is not present. The only distinction the
    KeyAccumulator needs is whether it collects keys for for-in (is_for_in_) or not.
    ForInFilter performs a separate step to filter out non-enumerable keys later-on
    while in all the other use-cases we have to filter keys.
    
    BUG=v8:1543, v8:5250
    
    Review-Url: https://codereview.chromium.org/2176113009
    Cr-Commit-Position: refs/heads/master@{#38199}
    f4f06c50
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...