• Michael Lippautz's avatar
    Revert "cppgc: Rework prefinalizers" · f46c4858
    Michael Lippautz authored
    This reverts commit cf25b3bc.
    
    Reason for revert: https://crbug.com/1307471. TraceTrait must only be used during marking.
    
    Original change's description:
    > cppgc: Rework prefinalizers
    >
    > Move the check for whether an object is live or dead out of the
    > prefinalizer trampoline. Moving it into the backend allows for
    > inlining the check which avoids a call to the trampoline for live
    > objects.
    >
    > On catapult benchmarks (e.g. cnn:2021, nytimes:2020), there's often
    > ~2k finalizers registered. In order to avoid memory overhead in the
    > range of a few KB, we store the fact whether the object points to the
    > base object payload in the LSB of the pointer. For caged builds this
    > is replaced with just storing the index into the cage for both object
    > and base object payload.
    >
    > Locally saves around ~10% of atomic sweeping processing time which is
    > in the order of .05ms.
    >
    > Bug: v8:12698
    > Change-Id: I198205a6b1d57fc2df821ee4e73e53dc6f825ff5
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497764
    > Reviewed-by: Omer Katz <omerkatz@chromium.org>
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#79442}
    
    Bug: v8:12698, chromium:1307471
    Change-Id: I5c4e70d46cb99af66c77f0c013625b6af6c6eb8e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3535781
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79527}
    f46c4858
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...