• Jakob Gruber's avatar
    [compiler] Support non-branch continuations for StackPointerGreaterThan · f42870ae
    Jakob Gruber authored
    We previously had a DCHECK to protect the assumption that the
    continuation to StackPointerGreaterThan must be a branch. This is not
    a valid assumption to make, in fact the second callsite of
    VisitStackPointerGreaterThan immediately violates it.
    
    Instead, this CL additionally considers non-branch continuations when
    getting the effect level.
    
    A slight digression since it was not clear to me how comparison
    results were materialized for 'Set' continuations: this happens during
    codegen, where CodeGenerator::AssembleInstruction inserts a call to
    AssembleArchBoolean if necessary.
    
    Bug: v8:9829,v8:9534
    Change-Id: Ib554071b7aa33e0f6b8a0d605219db6b6dc7d5b0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871912Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64430}
    f42870ae
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...