• Yang Guo's avatar
    Revert "[turbofan] Rewrite CompilationDependencies" · b1cf1e1e
    Yang Guo authored
    This reverts commit 52a10e50.
    
    Reason for revert: https://test-results.appspot.com/data/layout_results/V8-Blink_Linux_64__dbg_/12434/layout-test-results/results.html
    
    Crash e.g. in http/tests/devtools/oopif/oopif-performance-cpu-profiles.js
    
    crash log for devtools (pid <unknown>):
    STDOUT: <empty>
    STDERR: 
    STDERR: 
    STDERR: #
    STDERR: # Fatal error in ../../v8/src/compilation-dependencies.cc, line 281
    STDERR: # Debug check failed: descriptor == owner->LastAdded() (10 vs. 22).
    STDERR: #
    STDERR: #
    STDERR: #
    STDERR: #FailureMessage Object: 0x7fff86878630#0 0x0000031c642c base::debug::StackTrace::StackTrace()
    STDERR: #1 0x0000046a56bb gin::(anonymous namespace)::PrintStackTrace()
    STDERR: #2 0x00000469c528 V8_Fatal()
    STDERR: #3 0x00000469c285 v8::base::(anonymous namespace)::DefaultDcheckHandler()
    STDERR: #4 0x000001cc5253 v8::internal::CompilationDependencies::DependOnFieldType()
    STDERR: #5 0x000001cdcc46 v8::internal::compiler::AccessInfoFactory::ComputePropertyAccessInfo()
    STDERR: #6 0x000001cde661 v8::internal::compiler::AccessInfoFactory::ComputePropertyAccessInfos()
    STDERR: #7 0x000001dd982b v8::internal::compiler::JSNativeContextSpecialization::ReduceNamedAccess()
    STDERR: #8 0x000001ddb715 v8::internal::compiler::JSNativeContextSpecialization::ReduceNamedAccessFromNexus()
    STDERR: #9 0x000001dd656d v8::internal::compiler::JSNativeContextSpecialization::ReduceJSLoadNamed()
    STDERR: #10 0x000001d53872 v8::internal::compiler::GraphReducer::Reduce()
    STDERR: #11 0x000001d534a5 v8::internal::compiler::GraphReducer::ReduceTop()
    STDERR: #12 0x000001d52e58 v8::internal::compiler::GraphReducer::ReduceNode()
    STDERR: #13 0x000001e4c201 v8::internal::compiler::InliningPhase::Run()
    STDERR: #14 0x000001e44f79 v8::internal::compiler::PipelineImpl::Run<>()
    STDERR: #15 0x000001e41058 v8::internal::compiler::PipelineImpl::CreateGraph()
    STDERR: #16 0x000001e40c75 v8::internal::compiler::PipelineCompilationJob::PrepareJobImpl()
    STDERR: #17 0x000001ccd437 v8::internal::OptimizedCompilationJob::PrepareJob()
    STDERR: #18 0x000001cd071e v8::internal::(anonymous namespace)::GetOptimizedCode()
    STDERR: #19 0x000001cd0c6f v8::internal::Compiler::CompileOptimized()
    STDERR: #20 0x00000231fb62 v8::internal::__RT_impl_Runtime_CompileOptimized_Concurrent()
    STDERR: #21 0x00000288e535 <unknown>
    
    Original change's description:
    > [turbofan] Rewrite CompilationDependencies
    > 
    > Instead of installing code dependencies during graph reduction,
    > install them after code generation.
    > 
    > Bug: v8:7902, v8:7790
    > Change-Id: I8a3798254abb5b9ec7c295a1592aeb6b51f24c7a
    > Reviewed-on: https://chromium-review.googlesource.com/1119913
    > Commit-Queue: Georg Neis <neis@chromium.org>
    > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#54170}
    
    TBR=mstarzinger@chromium.org,jarin@chromium.org,neis@chromium.org
    
    Change-Id: Ic58c2bfadbd34bb6ba7dc0d2b74871cc90b0a74f
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7902, v8:7790
    Reviewed-on: https://chromium-review.googlesource.com/1125680Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54192}
    b1cf1e1e
Name
Last commit
Last update
..
OWNERS Loading commit data...
array-buffer-collector.cc Loading commit data...
array-buffer-collector.h Loading commit data...
array-buffer-tracker-inl.h Loading commit data...
array-buffer-tracker.cc Loading commit data...
array-buffer-tracker.h Loading commit data...
barrier.h Loading commit data...
code-stats.cc Loading commit data...
code-stats.h Loading commit data...
concurrent-marking.cc Loading commit data...
concurrent-marking.h Loading commit data...
embedder-tracing.cc Loading commit data...
embedder-tracing.h Loading commit data...
factory-inl.h Loading commit data...
factory.cc Loading commit data...
factory.h Loading commit data...
gc-idle-time-handler.cc Loading commit data...
gc-idle-time-handler.h Loading commit data...
gc-tracer.cc Loading commit data...
gc-tracer.h Loading commit data...
heap-controller.cc Loading commit data...
heap-controller.h Loading commit data...
heap-inl.h Loading commit data...
heap.cc Loading commit data...
heap.h Loading commit data...
incremental-marking-inl.h Loading commit data...
incremental-marking-job.cc Loading commit data...
incremental-marking-job.h Loading commit data...
incremental-marking.cc Loading commit data...
incremental-marking.h Loading commit data...
invalidated-slots-inl.h Loading commit data...
invalidated-slots.cc Loading commit data...
invalidated-slots.h Loading commit data...
item-parallel-job.cc Loading commit data...
item-parallel-job.h Loading commit data...
local-allocator.h Loading commit data...
mark-compact-inl.h Loading commit data...
mark-compact.cc Loading commit data...
mark-compact.h Loading commit data...
marking.cc Loading commit data...
marking.h Loading commit data...
memory-reducer.cc Loading commit data...
memory-reducer.h Loading commit data...
object-stats.cc Loading commit data...
object-stats.h Loading commit data...
objects-visiting-inl.h Loading commit data...
objects-visiting.cc Loading commit data...
objects-visiting.h Loading commit data...
remembered-set.h Loading commit data...
scavenge-job.cc Loading commit data...
scavenge-job.h Loading commit data...
scavenger-inl.h Loading commit data...
scavenger.cc Loading commit data...
scavenger.h Loading commit data...
setup-heap-internal.cc Loading commit data...
slot-set.h Loading commit data...
spaces-inl.h Loading commit data...
spaces.cc Loading commit data...
spaces.h Loading commit data...
store-buffer.cc Loading commit data...
store-buffer.h Loading commit data...
stress-marking-observer.cc Loading commit data...
stress-marking-observer.h Loading commit data...
stress-scavenge-observer.cc Loading commit data...
stress-scavenge-observer.h Loading commit data...
sweeper.cc Loading commit data...
sweeper.h Loading commit data...
worklist.h Loading commit data...