• Georg Neis's avatar
    Reland "Reland "Introduce MutableHeapNumber class."" · f1c79e02
    Georg Neis authored
    This is a reland of f0bcbc90.
    A few casts were still wrong.
    
    Original change's description:
    > Reland "Introduce MutableHeapNumber class."
    >
    > This is a reland of 40ac6b18, which
    > was incorrect due to a bad merge.
    >
    > Original change's description:
    > > Introduce MutableHeapNumber class.
    > >
    > > V8 knows heap numbers and mutable heap numbers. They have
    > > difference instance types, but in C++ code we've used the
    > > same class for both (HeapNumber). Confusingly, however,
    > > IsHeapNumber would return false for mutable heap numbers,
    > > while HeapNumber::cast would succeed.
    > >
    > > This CL adds a separate class MutableHeapNumber and
    > > eliminates the confusing behavior.
    > >
    [...]
    > TBR=bmeurer@chromium.org
    > TBR=ulan@chromium.org
    >
    > Change-Id: I3af1014c949821dfac0754a3e48c65ce1bad1ad1
    > Reviewed-on: https://chromium-review.googlesource.com/1114539
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Commit-Queue: Georg Neis <neis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#54022}
    
    Change-Id: I19a33da4b6abcd445b528a84d4f56ba1964d337b
    Reviewed-on: https://chromium-review.googlesource.com/1114100
    Commit-Queue: Georg Neis <neis@chromium.org>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54027}
    f1c79e02
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...