• ahaas's avatar
    [arm64][turbofan] Fix add+shr for big shift values. · ed6e28d2
    ahaas authored
    Arm64 compiles "x +_64 (y >> shift)" into a single instruction if
    "shift" is a constant. The code generator expects that "shift" is a
    32 bit constant. however, TurboFan can also pass in a 64 bit constant,
    which caused a crash in the code generator.
    
    With this CL we cast the constant of TurboFan to an int in the
    instruction selector and thereby satisfy the assumption of the code
    generator. This should be correct since the code generator anyways cast
    the "shift" to an int5 or int6 eventually.
    
    R=v8-arm-ports@googlegroups.com
    BUG=v8:5923
    
    Review-Url: https://codereview.chromium.org/2669203005
    Cr-Commit-Position: refs/heads/master@{#43036}
    ed6e28d2
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...