• Simon Zünd's avatar
    [stack-trace] Change column number for wasm frames to module offset · f16f0bcc
    Simon Zünd authored
    The CL https://crrev.com/c/1646846 changed column numbers for Wasm
    frames in Error.stack traces. Instead of using the offset relative to
    the beginning of the function, the absolute offset inside the module
    is displayed as hex.
    
    This CL propagates that change to the StackTrace C++ API, so
    StackFrame::GetColumn() also returns the absolute offset. Note that the
    StackFrame API historically uses "0" to signal "no information", so the
    line and column numbers for Wasm frames are also adjusted to 1-based,
    even though they signify function index and absolute offset
    into the module.
    
    This CL does not touch Script::PositionInfo.column. That field still
    contains the offset relative to the function start.
    
    Bug: v8:8742
    Change-Id: If4fd37fa681c7ebd0823ce0d95eccc1335c35272
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1655300
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62171}
    f16f0bcc
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...