• Benedikt Meurer's avatar
    [inspector] Add `throwOnSideEffect` to `Runtime.callFunctionOn`. · 32328edd
    Benedikt Meurer authored
    In order to implement eager (side effect free) evaluation of arbitrary
    accessor properties correctly, we need the ability to call getters while
    guaranteeing that we don't trigger side effects. This is accomplished by
    adding a `throwOnSideEffect` flag to the `Runtime.callFunctionOn` API,
    similar to what's already available with the `Runtime.evaluate` and the
    `Debugger.evaluateOnCallFrame` APIs.
    
    Bug: chromium:1076820, chromium:1119900, chromium:1222114
    Change-Id: If2d6c51376669cbc71a9dd3c79403d24d62aee43
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3001360
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75556}
    32328edd
Name
Last commit
Last update
..
console Loading commit data...
counters Loading commit data...
cpu-profiler Loading commit data...
debugger Loading commit data...
heap-profiler Loading commit data...
regress Loading commit data...
runtime Loading commit data...
runtime-call-stats Loading commit data...
sessions Loading commit data...
type-profiler Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
frontend-channel.h Loading commit data...
inspector-test.cc Loading commit data...
inspector.status Loading commit data...
isolate-data.cc Loading commit data...
isolate-data.h Loading commit data...
json-parse-expected.txt Loading commit data...
json-parse.js Loading commit data...
print-method-not-found-expected.txt Loading commit data...
print-method-not-found.js Loading commit data...
protocol-test.js Loading commit data...
task-runner.cc Loading commit data...
task-runner.h Loading commit data...
tasks.cc Loading commit data...
tasks.h Loading commit data...
testcfg.py Loading commit data...
utils.cc Loading commit data...
utils.h Loading commit data...
wasm-inspector-test.js Loading commit data...