• Alexey Kozyatinskiy's avatar
    [inspector] do not call native accessor in Rumtime.getProperties · ea04c667
    Alexey Kozyatinskiy authored
    In current implementation Object.getOwnPropertyDescriptor calls native
    getter. It can produce side effects. We can avoid calling it.
    DevTools frontend will show clickable dots and on click returns value.
    This CL does not affect Blink and only affect several Node.js
    properties, e.g. process.title.
    
    R=yangguo@chromium.org
    
    Bug: v8:6945
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: I5764c779ceed4d50832edf68b2b4c6ee2c2dd65c
    Reviewed-on: https://chromium-review.googlesource.com/754223
    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49152}
    ea04c667
Name
Last commit
Last update
..
build Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
injected-script-source.js Loading commit data...
injected-script.cc Loading commit data...
injected-script.h Loading commit data...
injected_script_externs.js Loading commit data...
inspected-context.cc Loading commit data...
inspected-context.h Loading commit data...
inspector.gyp Loading commit data...
inspector.gypi Loading commit data...
inspector_protocol_config.json Loading commit data...
js_protocol-1.2.json Loading commit data...
js_protocol.json Loading commit data...
remote-object-id.cc Loading commit data...
remote-object-id.h Loading commit data...
search-util.cc Loading commit data...
search-util.h Loading commit data...
string-16.cc Loading commit data...
string-16.h Loading commit data...
string-util.cc Loading commit data...
string-util.h Loading commit data...
test-interface.cc Loading commit data...
test-interface.h Loading commit data...
v8-console-agent-impl.cc Loading commit data...
v8-console-agent-impl.h Loading commit data...
v8-console-message.cc Loading commit data...
v8-console-message.h Loading commit data...
v8-console.cc Loading commit data...
v8-console.h Loading commit data...
v8-debugger-agent-impl.cc Loading commit data...
v8-debugger-agent-impl.h Loading commit data...
v8-debugger-script.cc Loading commit data...
v8-debugger-script.h Loading commit data...
v8-debugger.cc Loading commit data...
v8-debugger.h Loading commit data...
v8-function-call.cc Loading commit data...
v8-function-call.h Loading commit data...
v8-heap-profiler-agent-impl.cc Loading commit data...
v8-heap-profiler-agent-impl.h Loading commit data...
v8-injected-script-host.cc Loading commit data...
v8-injected-script-host.h Loading commit data...
v8-inspector-impl.cc Loading commit data...
v8-inspector-impl.h Loading commit data...
v8-inspector-session-impl.cc Loading commit data...
v8-inspector-session-impl.h Loading commit data...
v8-internal-value-type.cc Loading commit data...
v8-internal-value-type.h Loading commit data...
v8-profiler-agent-impl.cc Loading commit data...
v8-profiler-agent-impl.h Loading commit data...
v8-regex.cc Loading commit data...
v8-regex.h Loading commit data...
v8-runtime-agent-impl.cc Loading commit data...
v8-runtime-agent-impl.h Loading commit data...
v8-schema-agent-impl.cc Loading commit data...
v8-schema-agent-impl.h Loading commit data...
v8-stack-trace-impl.cc Loading commit data...
v8-stack-trace-impl.h Loading commit data...
v8-value-utils.cc Loading commit data...
v8-value-utils.h Loading commit data...
wasm-translation.cc Loading commit data...
wasm-translation.h Loading commit data...