• Leszek Swirski's avatar
    Revert "fix: move V8_EXPORT_PRIVATE marks to prevent unresolvable references" · e9ff38bb
    Leszek Swirski authored
    This reverts commit 13a04aba.
    
    Reason for revert: Breaks v8 roll (https://chromium-review.googlesource.com/c/chromium/src/+/1698024)
    
    Original change's description:
    > fix: move V8_EXPORT_PRIVATE marks to prevent unresolvable references
    > 
    > This change fixes missing symbol errors in the Windows 10 on ARM build
    > of Node.js.
    > 
    > When a whole class is marked for export, all of its members are marked
    > as well. This can be a problem when inline members call undefined yet
    > inline members of other classes: the exported function will contain a
    > reference to the undefined inline function that should be satisfied at
    > link time, but because the other function is inline no symbol will be
    > produced that will satisfy that reference.
    > 
    > Clang gets around this by masking inlined class members from export
    > using /Fc:dllexportInlines-. This is why b0a2a567 worked.
    > 
    > Node.js' Windows builds use MSVC and so do not have access to this
    > flag. This results in unresolved symbols at link time.
    > 
    > Bug: v8:9465
    > Change-Id: Ief9c7ab6ba35d22f995939eb62a64d6f1992ed85
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1696771
    > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#62660}
    
    TBR=sigurds@chromium.org,jgruber@chromium.org,ishell@chromium.org,jkunkee@microsoft.com
    
    Change-Id: Ief2ccb35fc19b00975e78a63791a558525d49ee9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:9465
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1700069Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62694}
    e9ff38bb
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
assembler-arch.h Loading commit data...
assembler-inl.h Loading commit data...
assembler.cc Loading commit data...
assembler.h Loading commit data...
bailout-reason.cc Loading commit data...
bailout-reason.h Loading commit data...
callable.h Loading commit data...
code-comments.cc Loading commit data...
code-comments.h Loading commit data...
code-desc.cc Loading commit data...
code-desc.h Loading commit data...
code-factory.cc Loading commit data...
code-factory.h Loading commit data...
code-reference.cc Loading commit data...
code-reference.h Loading commit data...
code-stub-assembler.cc Loading commit data...
code-stub-assembler.h Loading commit data...
compilation-cache.cc Loading commit data...
compilation-cache.h Loading commit data...
compiler.cc Loading commit data...
compiler.h Loading commit data...
constant-pool.cc Loading commit data...
constant-pool.h Loading commit data...
constants-arch.h Loading commit data...
cpu-features.h Loading commit data...
external-reference-table.cc Loading commit data...
external-reference-table.h Loading commit data...
external-reference.cc Loading commit data...
external-reference.h Loading commit data...
flush-instruction-cache.cc Loading commit data...
flush-instruction-cache.h Loading commit data...
handler-table.cc Loading commit data...
handler-table.h Loading commit data...
interface-descriptors.cc Loading commit data...
interface-descriptors.h Loading commit data...
label.h Loading commit data...
machine-type.cc Loading commit data...
machine-type.h Loading commit data...
macro-assembler-inl.h Loading commit data...
macro-assembler.h Loading commit data...
optimized-compilation-info.cc Loading commit data...
optimized-compilation-info.h Loading commit data...
pending-optimization-table.cc Loading commit data...
pending-optimization-table.h Loading commit data...
register-arch.h Loading commit data...
register-configuration.cc Loading commit data...
register-configuration.h Loading commit data...
register.h Loading commit data...
reglist.h Loading commit data...
reloc-info.cc Loading commit data...
reloc-info.h Loading commit data...
safepoint-table.cc Loading commit data...
safepoint-table.h Loading commit data...
signature.h Loading commit data...
source-position-table.cc Loading commit data...
source-position-table.h Loading commit data...
source-position.cc Loading commit data...
source-position.h Loading commit data...
string-constants.cc Loading commit data...
string-constants.h Loading commit data...
turbo-assembler.cc Loading commit data...
turbo-assembler.h Loading commit data...
unoptimized-compilation-info.cc Loading commit data...
unoptimized-compilation-info.h Loading commit data...