• littledan's avatar
    Base the right RegExp brand checks on Symbol.match · e99d2929
    littledan authored
    The ES2015 specification requires that String.prototype.startsWith,
    String.prototype.endsWith and String.prototype.includes use the IsRegExp
    internal algorithm to determine whether to throw a TypeError to prevent
    a RegExp from being accidentally cast to a String for those methods.
    That internal algorithm checks the presence/truthiness of Symbol.match
    to make its determination. This patch switches the builtins to use
    this correct test, rather than checking for the [[RegExpMatcher]]
    internal slot as the builtins previously did.
    
    R=yangguo
    
    Review URL: https://codereview.chromium.org/1762183002
    
    Cr-Commit-Position: refs/heads/master@{#34547}
    e99d2929
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...