• Clemens Backes's avatar
    [flags] Store all flag values in a single struct · e99b43f8
    Clemens Backes authored
    Instead of defining one global (FLAG_foo) per flag, define all flag
    values as fields in a global {v8_flags} struct. This guarantees that the
    memory is contiguous, and together with proper alignment allows us to
    later memory-protect that memory space.
    
    In order to avoid rewriting all existing code that uses the {FLAG_foo}
    syntax, we define global aliases: {FLAG_foo} is a reference to
    {v8_flags.foo}.
    
    After the next branch cut (v10.6), follow-up CLs will rewrite all
    existing code to use the {v8_flags.foo} syntax, and after another branch
    cut (v10.7) the aliases will be removed.
    This should allow us to merge back most fixes to the previous branch
    (N-1). Merges to stable (N-2) might still require resolving merge
    conflicts manually, if they modify code that reads flags.
    
    R=cbruni@chromium.org
    CC=​sroettger@chromium.org
    
    Bug: v8:12887
    Change-Id: I8bc44429767f611484fe345d7268af1d55c98124
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810187
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82423}
    e99b43f8
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...