• Andreas Haas's avatar
    [wasm] Make WasmInterpreterInternals a normal object · e92e8871
    Andreas Haas authored
    For unknown reasons, WasmInterpreterInternals was a zone object. However
    WasmInterpreterInternals indirectly owns a global handle and a
    unique_ptr, both for the interpreter stack. As a zone object,
    WasmInterpreterInternals is never destructed, and therefore never frees
    the unique_ptr. With this CL I make WasmInterpreterInternals a normal
    object and allocate it into a unique_ptr, so that it gets destructed
    properly.
    
    R=mstarzinger@chromium.org
    
    Bug: chromium:1000610
    Change-Id: Ie08c5627393a434521f5c32702bf9945db2c7811
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1807361Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63835}
    e92e8871
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...