• caitpotter88's avatar
    reland [es7] refactor and fix Object.values() / Object.entries() · e708dd54
    caitpotter88 authored
    Previously, Object.values() and Object.entries() were piggy-backing on
    Object.keys(). This meant that they would pre-filter non-enumerable properties,
    violating the runtime behaviour of the methods. Unfortunately, this does not
    match the current proposal text.
    
    Also incorporates several tests verifying this behaviour based on tests included
    in the ChakraCore implementation.
    
    In this reland, the new patch fills up the longer-lasting FixedArray with
    `undefined` to avoid the crash in Heap::Verify().
    
    Originally reviewed at https://codereview.chromium.org/1637753004
    
    BUG=v8:4663
    LOG=N
    R=adamk@chromium.org, rossberg@chromium.org, littledan@chromium.org
    
    Review URL: https://codereview.chromium.org/1673673002
    
    Cr-Commit-Position: refs/heads/master@{#33818}
    e708dd54
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...