• Benedikt Meurer's avatar
    [turbofan] Introduce a pure StringConcat operator. · e56b6d24
    Benedikt Meurer authored
    This replaces the previous CheckStringAdd operator which deopts in case
    the combined length overflows with a dedicated pure StringConcat operator.
    This operator is similar to NewConsString in that it takes the resulting
    length plus the two input strings. The operator relies on the length
    being checked explicitly by the surrounding code instead of baking the
    check into the operator itself. This way TurboFan can eliminate
    redundant/unnecessary StringConcat operations, since they are pure now.
    
    This also unifies the treatment of string addition in JSTypedLowering,
    and generalizes the StringLength constant-folding to apply to more cases
    not just the JSAdd cases inside JSTypedLowering.
    
    Bug: v8:7902, v8:8015
    Change-Id: I987ec39815a9464fd5fd9c4f7b26b709f94f2b3f
    Reviewed-on: https://chromium-review.googlesource.com/1213205Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55725}
    e56b6d24
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...