• Clemens Hammacher's avatar
    [cleanup] Fix (D)CHECK macros in src/{debug,inspector} · 8d38c15e
    Clemens Hammacher authored
    Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an
    embedded comparison. This gives better error messages and also does the
    right comparison for signed/unsigned mismatches.
    
    This will allow us to reenable the readability/check cpplint check.
    
    R=yangguo@chromium.org
    
    Bug: v8:6837
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I88e5afea1ad0fdf23a81b380e64ff356bbc20112
    Reviewed-on: https://chromium-review.googlesource.com/681374Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48138}
    8d38c15e
Name
Last commit
Last update
..
console Loading commit data...
cpu-profiler Loading commit data...
debugger Loading commit data...
heap-profiler Loading commit data...
runtime Loading commit data...
sessions Loading commit data...
type-profiler Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
inspector-test.cc Loading commit data...
inspector.gyp Loading commit data...
inspector.isolate Loading commit data...
inspector.status Loading commit data...
isolate-data.cc Loading commit data...
isolate-data.h Loading commit data...
json-parse-expected.txt Loading commit data...
json-parse.js Loading commit data...
protocol-test.js Loading commit data...
task-runner.cc Loading commit data...
task-runner.h Loading commit data...
testcfg.py Loading commit data...