• Jakob Gruber's avatar
    [regexp] Fix invalid DCHECK in named capture logic · 5d5a6595
    Jakob Gruber authored
    The `capture_ix` refers to all captures while `capture_count` only
    refers to named captures. Clarified by renaming `capture_count` to
    `named_capture_count` and removing the incorrect part of the DCHECK.
    
    The `>= 1` part of the condition must still hold since named captures
    can only refer to explicit capture groups, which start at index 1.
    
    Tbr: petermarshall@chromium.org
    Bug: chromium:1018592
    Change-Id: If8a26f6661ba0483d585f74270b3b4a3853e2ca8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1886810Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64629}
    5d5a6595
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...