• littledan's avatar
    Ensure IteratorClose is called for errors in non-declaring assignments · 1aee7555
    littledan authored
    There was a bug in for-of loops without newly declared variables: If,
    in performing the assignment, an exception were thrown, then
    IteratorClose would not be called. The problem was that the assignment
    is done as part of assign_each, which happens before the loop is put
    back in the state which is recognized to be breaking/throwing/returning
    early.
    
    This patch modifies the for-of desugaring by setting the loop state
    before, rather than after, evaluating the assign_each portion, which is
    responsible for evaluating the assignment in for-of loops which do not
    have a declaration.
    
    This patch, together with https://codereview.chromium.org/1728973002 ,
    allow all test262 iterator return-related tests to pass.
    
    R=rossberg
    BUG=v8:4776
    LOG=Y
    
    Review URL: https://codereview.chromium.org/1731773003
    
    Cr-Commit-Position: refs/heads/master@{#34262}
    1aee7555
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
fuzzer Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
simdjs Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
webkit Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
ignition.gyp Loading commit data...
ignition.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...