• jfb's avatar
    Revert of [coverage] Filter some files from instrumentation. (patchset #3... · 4014f1c7
    jfb authored
    Revert of [coverage] Filter some files from instrumentation. (patchset #3 id:40001 of https://codereview.chromium.org/1730543002/ )
    
    Reason for revert:
    This breaks `gclient sync` because v8_target_arch isn't defined.
    
    gyp: name 'v8_target_arch' is not defined while evaluating condition
    '(OS=="linux" or OS=="mac") and (target_arch=="ia32" or target_arch=="x64") and
             (v8_target_arch!="x87" and v8_target_arch!="x32") and coverage==0' in
    /media/jfb/ssd/v8/v8/build/all.gyp
    Error: Command '/usr/bin/python v8/build/gyp_v8' returned non-zero exit status 1
    in /media/jfb/ssd/v8
    
    Original issue's description:
    > [coverage] Filter some files from instrumentation.
    >
    > This filters test and third_party files to get a speed-up
    > when running tests and when collecting profile data.
    >
    > BUG=chromium:568949
    > LOG=n
    >
    > Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
    > Cr-Commit-Position: refs/heads/master@{#34216}
    >
    > Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
    > Cr-Commit-Position: refs/heads/master@{#34253}
    
    TBR=tandrii@chromium.org,kjellander@chromium.org,machenbach@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=chromium:568949
    
    Review URL: https://codereview.chromium.org/1737433002
    
    Cr-Commit-Position: refs/heads/master@{#34258}
    4014f1c7
Name
Last commit
Last update
..
config/win Loading commit data...
mac Loading commit data...
OWNERS Loading commit data...
README.txt Loading commit data...
all.gyp Loading commit data...
detect_v8_host_arch.py Loading commit data...
download_gold_plugin.py Loading commit data...
features.gypi Loading commit data...
get_landmines.py Loading commit data...
gyp_environment.py Loading commit data...
gyp_v8 Loading commit data...
gyp_v8.py Loading commit data...
has_valgrind.py Loading commit data...
isolate.gypi Loading commit data...
landmine_utils.py Loading commit data...
landmines.py Loading commit data...
shim_headers.gypi Loading commit data...
standalone.gypi Loading commit data...
toolchain.gypi Loading commit data...
vs_toolchain.py Loading commit data...