-
Marja Hölttä authored
The hard-coded timeout in the test is so near, that e.g., adding DCHECKs pushes the test over the limit. The test is ran with dcheck_always_on=true. We shouldn't do any performance testing with dcheck_always_on=true; this creates the wrong incentive to not add DCHECKs (or in this case, CLs which add more DCHECKs or cause more DCHECKs to be hit cannot land at all). Change-Id: Ia4d1b2b17ce5a5330b929f984253c89ba273f661 Reviewed-on: https://chromium-review.googlesource.com/1046548Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#53032}
e14ed48c
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
benchmarks | ||
cctest | ||
common | ||
debugger | ||
fuzzer | ||
inspector | ||
intl | ||
js-perf-test | ||
memory | ||
message | ||
mjsunit | ||
mkgrokdump | ||
mozilla | ||
preparser | ||
test262 | ||
unittests | ||
wasm-spec-tests | ||
webkit | ||
BUILD.gn |