• Leszek Swirski's avatar
    [sparkplug] Fix invalid stack on baseline install · b4e62f2d
    Leszek Swirski authored
    InterpreterOnStackReplacement_ToBaseline spills the accumulator register
    without a frame, but can then call kInstallBaselineCode. If that
    function then allocates, then the GC will see an invalid stack.
    
    Fix this by making sure that the accumulator register is spilled inside
    the internal frame of the kInstallBaselineCode, and either don't spill
    it at all outside that frame, or at least make sure that we pop/re-push
    the spilled value so that it moves inside the frame.
    
    Bug: v8:11420
    Change-Id: Iad2aa718b0477ff960544d881fecae9efcbeef54
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059072
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75978}
    b4e62f2d
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...