• jkummerow's avatar
    Revert of improve perf_basic_prof filename reporting (patchset #1 id:1 of... · e03df522
    jkummerow authored
    Revert of improve perf_basic_prof filename reporting (patchset #1 id:1 of https://codereview.chromium.org/1388543002/ )
    
    Reason for revert:
    Suspected to cause crbug.com/539892
    
    Original issue's description:
    > improve perf_basic_prof filename reporting
    >
    > The buffer used for appending filenames to the string printed to the
    > perf_basic_prof log was unnecessarily too small. Bump it up to be at least
    > kUtf8BufferSize.
    >
    > Truncation of filenames makes it really hard to work with profiles gathered on
    > Node.js. Because of the way Node.js works, you can have node module dependencies
    > in deeply nested directories. The last thing you want when investigating a
    > performance problem is to have script names be truncated.
    >
    > This patch is a stop-gap. Ideally, I want no truncation of the filename at all
    > and use a dynamically growing buffer. That would be a larger change, and I
    > wanted to have a quick fix available that can be back-ported to Node.js LTS
    > release.
    >
    > R=yangguo@chromium.org,yurys@chromium.org
    > BUG=
    >
    > Committed: https://crrev.com/03ef3cd004c2fd31ae7e48772f106df67b8c2feb
    > Cr-Commit-Position: refs/heads/master@{#31092}
    
    TBR=yangguo@chromium.org,yurys@chromium.org,ofrobots@google.com
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=
    
    Review URL: https://codereview.chromium.org/1390923004
    
    Cr-Commit-Position: refs/heads/master@{#31137}
    e03df522
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...