• Jakob Kummerow's avatar
    [ubsan] Check valid types on ExternalReference-called functions · df99becf
    Jakob Kummerow authored
    All C++ functions called directly from generated code must have
    a predictable ABI. We ensure that by requiring their return and
    argument types to be scalars -- in particular, they must not be
    non-pointer ObjectPtr or ObjectSlot types, which is easy to get
    wrong and difficult to debug. This patch adds compile-time type
    checks enforcing the requirement to the macro used for creating
    ExternalReferences for functions.
    
    Bug: v8:3770
    Change-Id: I442cf25e2f72b7ea84d4a50c9c665b187b179ca0
    Reviewed-on: https://chromium-review.googlesource.com/c/1334974
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57560}
    df99becf
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...