• Leszek Swirski's avatar
    [arm] Make the constant pool check deadline smarter · df4dae77
    Leszek Swirski authored
    Rather than having periodic constant pool checks that almost always fail
    (because the constant pool deadline isn't close enough, or even because
    there's no constant pool to emit at all), set a single deadline on the
    first constant pool insertion which expires just before the maximum
    distance to the constant pool. Constant pool checks around unconditional
    jumps happen irrespective of this deadline.
    
    In particular, this is made possible by fixing the incorrect assumption
    that the constant pool can be emitted out of order. The new assumption
    (that the emission is in-order) is validated with a CHECK.
    
    Bug: v8:11420
    Change-Id: I061dd0b8c3476ba95ee1acfb3b485d8ba2adda91
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2844665
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74141}
    df4dae77
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...