• Milad Fa's avatar
    PPC/s390: [compiler] Always use full version of RecordWrite builtin · ddc409cb
    Milad Fa authored
    Port 1b437aa8
    
    Original Commit Message:
    
        When we know that the value in a write barrier is a map, we know that
        we are not going to have an old-to-new reference (maps are always in
        old generation). Therefore we also don't really need the generational
        barrier in RecordWrite. While this is technically correct, we don't
        gain much from this optimization. The inline and out-of-line generated
        code for the barrier is still the same as in all other cases. Which
        means that outside marking we don't even reach the RecordWrite builtin.
        Most write barrier executions happen outside incremental marking, hence
        performance of the incremental marking barrier isn't critical. This CL
        always uses the full RecordWrite builtin using a flag in order to
        allow for an easy revert.
    
        This CL is motivated by the shared heap work, which needs an additional
        always-on barrier in the future (similar to OLD_TO_NEW) to keep a
        OLD_TO_SHARED remembered set up-to-date. While maps are always in the
        old generation, they maybe by located in the shared heap.
    
    R=dinfuehr@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com
    BUG=
    LOG=N
    
    Change-Id: I4e763419b3b007a668073e1577cbff9127d15940
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3481263Reviewed-by: 's avatarJoran Siu <joransiu@ca.ibm.com>
    Reviewed-by: 's avatarJunliang Yan <junyan@redhat.com>
    Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
    Cr-Commit-Position: refs/heads/main@{#79214}
    ddc409cb
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...