• Maya Lekova's avatar
    Revert "[wasm] Store compile errors in CompilationState" · dd5c3631
    Maya Lekova authored
    This reverts commit bf3d7b9a.
    
    Reason for revert: Breaks TSAN build, see
    https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/23248
    
    Original change's description:
    > [wasm] Store compile errors in CompilationState
    > 
    > We are currently storing compilation errors in the individual
    > compilation units and pass it to the ErrorThrower during finishing.
    > This CL changes that to store errors on the CompilationState directly.
    > From there, it is propagated to the ErrorThrower in the compilation
    > state callback.
    > This removes more work from the finisher task and slims down the
    > WasmCompilationUnits.
    > 
    > R=​mstarzinger@chromium.org
    > 
    > Bug: v8:8343, v8:7921
    > Change-Id: Id332add43d4219d2a30fee653ed4e53a9b2698d9
    > Reviewed-on: https://chromium-review.googlesource.com/c/1303720
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#57091}
    
    TBR=mstarzinger@chromium.org,clemensh@chromium.org
    
    Change-Id: Id32c7337494a4749485adbcfcaae7b2331afea66
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8343, v8:7921
    Reviewed-on: https://chromium-review.googlesource.com/c/1304544Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57094}
    dd5c3631
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...