• Clemens Backes's avatar
    Revert "[wasm][liftoff] Cache the memory start register" · dd4d29a2
    Clemens Backes authored
    This reverts commit fd93f338.
    
    Reason for revert: Out of bounds errors in Unity benchmark (link is internal).
    
    Original change's description:
    > [wasm][liftoff] Cache the memory start register
    >
    > WebAssembly functions often have subsequent memory accesses, and each of
    > these memory accesses need the start address of the memory in a register.
    > With this CL the register with the memory start address is cached, so
    > only the first memory access has to load the memory start address into a
    > register, subsequent memory accesses can just reuse the register.
    >
    > In first measurements with the epic benchmark this reduces the size of
    > the generated Liftoff code by a bit more than 5%.
    >
    > R=​clemensb@chromium.org
    >
    > Bug: v8:11862
    > Change-Id: Ic33e7e3c00a4209570821269c728187affbeadcf
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2947403
    > Commit-Queue: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#75113}
    
    Bug: v8:11862
    Change-Id: I20c7e7d729cf9846499db90c02f8581d7f994ace
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960216
    Auto-Submit: Clemens Backes <clemensb@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#75132}
    dd4d29a2
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...