• Clemens Backes's avatar
    Reland "[wasm] Move write scope out of NativeModule::AddCode" · dd152c48
    Clemens Backes authored
    This is a reland of 6ae18c2d, with
    {CompileWasmCapiCallWrapper} fixed to also contain a
    {CodeSpaceWriteScope}.
    
    Original change's description:
    > [wasm] Move write scope out of NativeModule::AddCode
    >
    > {NativeModule::AddCode} is a central method that should usually be
    > called in batches, where the caller holds a {CodeSpaceWriteScope} for a
    > longer time (over several compilations).
    > This CL moves us closer to that by removing the scope from that central
    > method and instead putting it in callers where it becomes more visible.
    > There are already TODOs to introduce caching or batching to avoid some
    > switching, and one more TODO is added.
    >
    > Drive-by: Remove an unneeded {CodeSpaceMemoryModificationScope}.
    >
    > R=jkummerow@chromium.org
    >
    > Bug: v8:11974
    > Change-Id: Ia13c601abc766e5fca6ca053bf1fc4d647b53ed0
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3098186
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#76344}
    
    Bug: v8:11974
    Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_dbg_ng
    Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_rel_ng
    Change-Id: I6367bbd9dc52c403513eb1a168aa1f6eb4044ca1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3129703Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76626}
    dd152c48
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...