• Benedikt Meurer's avatar
    [turbofan] Properly handle smis in monomorphic loads/stores. · a9da0ce7
    Benedikt Meurer authored
    When lowering a monomorphic load/store, where multiple receiver maps
    have been recorded, but the action to be performed is the same (i.e.
    yielding undefined because the property is not found), TurboFan used
    to ignore the Smi case, leading to a pretty terrible deoptimization
    loop, as the LOAD_IC/STORE_IC properly recorded that state and thus
    didn't change it's state.
    
    Fixing this issue gives a 18-20% boost on the prettier test of the
    web-tooling-benchmark, which was suffering a lot from this problem.
    
    Bug: v8:6936, v8:6991
    Change-Id: Id208ec7129a7f6b190d989bda31f936040393226
    Reviewed-on: https://chromium-review.googlesource.com/735342Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48865}
    a9da0ce7
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...