• Benedikt Meurer's avatar
    [inspector] Gracefully ignore non-dictionary values as session state. · dc3eb449
    Benedikt Meurer authored
    The V8InspectorSessionImpl constructor accepts a state, as either text
    or CBOR encoded, and generally ignores all invalid inputs, except for
    the case where it's a valid value, but not a dictionary value, in which
    case it'll leak the value and crash upon casting to a `DictionaryValue`.
    
    This is purely an issue with the test driver, so no security impact on
    Chromium in the wild.
    
    Fixed: chromium:1281031
    Change-Id: I7b4d0aea83370499b1274d3fa214a14dc098d2f2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3361838
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78490}
    dc3eb449
Name
Last commit
Last update
..
console Loading commit data...
cpu-profiler Loading commit data...
debugger Loading commit data...
heap-profiler Loading commit data...
regress Loading commit data...
runtime Loading commit data...
sessions Loading commit data...
type-profiler Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
frontend-channel.h Loading commit data...
inspector-test.cc Loading commit data...
inspector.status Loading commit data...
isolate-data.cc Loading commit data...
isolate-data.h Loading commit data...
json-parse-expected.txt Loading commit data...
json-parse.js Loading commit data...
print-method-not-found-expected.txt Loading commit data...
print-method-not-found.js Loading commit data...
protocol-test.js Loading commit data...
task-runner.cc Loading commit data...
task-runner.h Loading commit data...
tasks.cc Loading commit data...
tasks.h Loading commit data...
testcfg.py Loading commit data...
utils.cc Loading commit data...
utils.h Loading commit data...
wasm-inspector-test.js Loading commit data...