• Clemens Hammacher's avatar
    Remove FixedArray::GetValueChecked · daa26679
    Clemens Hammacher authored
    This method is rarely used, and has several problems:
    1) It CHECKs that the value is not undefined, then creates a
       {Handle<T>} which again DCHECKs that the value is of type {T}.
    2) It is called on a raw {FixedArray} but returns a handle.
    3) It is often used when no handle is actually needed, adding
       unnecessary overhead.
    4) It adds complexity and hides actual checks and handlification.
    
    This CL removes that method, replacing some uses by explicit CHECKs (in
    tests) and relying on the DCHECKs in the casts otherwise.
    
    R=mstarzinger@chromium.org
    
    Bug: v8:9183
    Change-Id: I90ff59e8b78c909a9a207029d8cc9ab16c0c7b56
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621939
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61710}
    daa26679
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...