• Clemens Hammacher's avatar
    [wasm] Do not pass the error to callbacks · d928d25c
    Clemens Hammacher authored
    Instead of passing the error explicitly, make the callbacks get the
    error from the CompilationState. This prepares a change to call the
    callbacks asynchronously, because from the background we cannot
    construct the final error message (because this requires access to the
    wire bytes). Thus the callbacks will have to get the actual compile
    error from the CompilationState from a foreground task if they need it.
    
    R=mstarzinger@chromium.org
    
    Bug: v8:8689
    Change-Id: I22accabf895bf21fa7492e2f5cb8bac93237c765
    Reviewed-on: https://chromium-review.googlesource.com/c/1445975
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59216}
    d928d25c
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...