• Jan Krems's avatar
    Allow quotes inside of embedded sourceMappingURLs · a73550bd
    Jan Krems authored
    The original implementation of matching was a RegExp on the source
    which wasn't able to reliably distinguish between comments inside
    of string literals and actual comments. For that reason, it had
    a special rule to disallow quotes to remove false positives.
    
    Original comment:
    > Also, ['"] are excluded from allowed URLs to  avoid matches
    > against sources that invoke evals with sourceURL.
    
    After the code was moved into the scanner, that shouldn't be an
    issue anymore - the scanner knows that this is a real comment and
    isn't part of a string literal.
    
    Allowing quotes enables a slightly smaller encoding of source maps,
    specifically in the case where there are no sourceContents:
    Non-base64 source maps can get away with effectively no encoding
    overhead (they typically don't contain whitespace).
    
    Change-Id: Iffa5df28d80656fa56e603e7c0e57aa1f44d0014
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2576801Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Auto-Submit: Jan Krems <jankrems@google.com>
    Commit-Queue: Jan Krems <jankrems@google.com>
    Cr-Commit-Position: refs/heads/master@{#71742}
    a73550bd
Name
Last commit
Last update
..
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
expression-scope.h Loading commit data...
func-name-inferrer.cc Loading commit data...
func-name-inferrer.h Loading commit data...
import-assertions.cc Loading commit data...
import-assertions.h Loading commit data...
keywords-gen.h Loading commit data...
keywords.txt Loading commit data...
literal-buffer.cc Loading commit data...
literal-buffer.h Loading commit data...
parse-info.cc Loading commit data...
parse-info.h Loading commit data...
parser-base.h Loading commit data...
parser.cc Loading commit data...
parser.h Loading commit data...
parsing.cc Loading commit data...
parsing.h Loading commit data...
pending-compilation-error-handler.cc Loading commit data...
pending-compilation-error-handler.h Loading commit data...
preparse-data-impl.h Loading commit data...
preparse-data.cc Loading commit data...
preparse-data.h Loading commit data...
preparser-logger.h Loading commit data...
preparser.cc Loading commit data...
preparser.h Loading commit data...
rewriter.cc Loading commit data...
rewriter.h Loading commit data...
scanner-character-streams.cc Loading commit data...
scanner-character-streams.h Loading commit data...
scanner-inl.h Loading commit data...
scanner.cc Loading commit data...
scanner.h Loading commit data...
token.cc Loading commit data...
token.h Loading commit data...