• Dominik Inführ's avatar
    [heap] Add and remove allocation observers without using safepoints · d79e0c4f
    Dominik Inführ authored
    Safepoints were used in Heap::AddAllocationObserversToAllSpaces and
    Heap::RemoveAllocationObserversFromAllSpaces as a poor man's approach
    to synchronization. This CL removes the safepoint and protects the
    potential race on the free list with a mutex in
    PagedSpace::DecreaseLimit.
    
    The motivation for this CL is that SafepointScope might possibly park
    the main thread in the future. However parking is only allowed if GCs
    are also allowed. GCs are not allowed when running allocation observers,
    so an allocation observer would not be able to add or remove additional
    observers as is currently done in StressConcurrentAllocationObserver.
    
    Also adding additional checks to the safepoint to ensure that we are
    on the main thread.
    
    Bug: v8:11708
    Change-Id: I4e65a83ac4015d30b15d8c4eeaed4ea759b7c982
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3160523
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76867}
    d79e0c4f
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...