• Bill Budge's avatar
    Revert "Reland "Reland "Reland "[compiler][wasm] Align Frame slots to value size"""" · 942af6c7
    Bill Budge authored
    This reverts commit 9da4e363.
    
    Reason for revert: Fuzzers revealed that Liftoff doesn't use the CallDescriptor when pushing arguments, breaking linkage.
    
    tbr=ahaas@chromium.org,neis@chromium.org,jgruber@chromium.org
    
    Original change's description:
    > Reland "Reland "Reland "[compiler][wasm] Align Frame slots to value size"""
    >
    > This is a reland of 352b9ecb
    >
    > The test/fix CL has been merged in, as the fixes to return slot
    > accounting are needed to fix Arm64 issues turned up by the fuzzers:
    >
    > https://chromium-review.googlesource.com/c/v8/v8/+/2644139
    >
    > Original change's description:
    > > Reland "Reland "[compiler][wasm] Align Frame slots to value size""
    > >
    > > This is a reland of 1694925c
    > >
    > > Minor fix to linkage for constexpr.
    > >
    > > TBR=ahaas@chromium.org,neis@chromium.org
    > >
    > > Original change's description:
    > > > Reland "[compiler][wasm] Align Frame slots to value size"
    > > >
    > > > This is a reland of cddaf66c
    > > >
    > > > Original change's description:
    > > > > [compiler][wasm] Align Frame slots to value size
    > > > >
    > > > > - Adds an AlignedSlotAllocator class and tests, to unify slot
    > > > >   allocation. This attempts to use alignment holes for smaller
    > > > >   values.
    > > > > - Reworks Frame to use the new allocator for stack slots.
    > > > > - Reworks LinkageAllocator to use the new allocator for stack
    > > > >   slots and for ARMv7 FP register aliasing.
    > > > > - Fixes the RegisterAllocator to align spill slots.
    > > > > - Fixes InstructionSelector to align spill slots.
    > > > >
    > > > > Bug: v8:9198
    > > > >
    > > > > Change-Id: Ida148db428be89ef95de748ec5fc0e7b0358f523
    > > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512840
    > > > > Commit-Queue: Bill Budge <bbudge@chromium.org>
    > > > > Reviewed-by: Georg Neis <neis@chromium.org>
    > > > > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > > > > Cr-Commit-Position: refs/heads/master@{#71644}
    > > >
    > > > Bug: v8:9198
    > > > Change-Id: Ib91fa6746370c38496706341e12d05c7bf999389
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2633390
    > > > Commit-Queue: Bill Budge <bbudge@chromium.org>
    > > > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > > > Reviewed-by: Georg Neis <neis@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#72195}
    > >
    > > Bug: v8:9198
    > > Change-Id: I91e02b823af8ec925dacf075388fb22e3eeb3384
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2640890
    > > Reviewed-by: Bill Budge <bbudge@chromium.org>
    > > Commit-Queue: Bill Budge <bbudge@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#72209}
    >
    > Bug: v8:9198
    > Change-Id: I8258f87463f66417c7028b9a1fed4b9b6d82a3be
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2669892
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Commit-Queue: Bill Budge <bbudge@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#72506}
    
    Bug: v8:9198
    Change-Id: I7f344e4d018ce3c02333b0b08efeecdd8cddf082
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2713207Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Reviewed-by: 's avatarZhi An Ng <zhin@chromium.org>
    Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Bill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72937}
    942af6c7
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regress Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...