• Omer Katz's avatar
    cppgc: Handle low-address stack in write barrier. · 649d3c10
    Omer Katz authored
    Windows can allocate the stack at low addresses. A low-address on-stack
    slot (e.g. backing store reference for Blink's on-heap collections) with
    a null value would make TryGetCagedHeap falsely think that the slot
    resides in a caged heap that starts at a null address.
    
    We will still crash for low-address on-stack slots with non-null
    on-stack value, since these cases are not considered valid and should
    not happen.
    
    The null value check is added only to Windows. It is not an issue on
    other OSes where the stack always resides at high addresses and we
    prefer to keep the write barrier as cheap as possible.
    
    Bug: chromium:1230794, chromium:1056170
    Change-Id: I07e2d178cd95edba57015d6bc6eb127a443b0589
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3069146
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Reviewed-by: 's avatarAnton Bikineev <bikineev@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76069}
    649d3c10
Name
Last commit
Last update
..
cppgc Loading commit data...
libplatform Loading commit data...
APIDesign.md Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
js_protocol-1.2.json Loading commit data...
js_protocol-1.3.json Loading commit data...
js_protocol.pdl Loading commit data...
v8-cppgc.h Loading commit data...
v8-fast-api-calls.h Loading commit data...
v8-inspector-protocol.h Loading commit data...
v8-inspector.h Loading commit data...
v8-internal.h Loading commit data...
v8-metrics.h Loading commit data...
v8-platform.h Loading commit data...
v8-profiler.h Loading commit data...
v8-unwinder-state.h Loading commit data...
v8-util.h Loading commit data...
v8-value-serializer-version.h Loading commit data...
v8-version-string.h Loading commit data...
v8-version.h Loading commit data...
v8-wasm-trap-handler-posix.h Loading commit data...
v8-wasm-trap-handler-win.h Loading commit data...
v8.h Loading commit data...
v8config.h Loading commit data...