• Joshua Litt's avatar
    Reland "[regexp] Clone match info for match indices." · d4574d18
    Joshua Litt authored
    This reverts commit d7793c06.
    
    Reason for revert: This cl *will* cause regexp regressions. We are trying to gauge the real world impact.
    
    Original change's description:
    > Revert "[regexp] Clone match info for match indices."
    >
    > This reverts commit dfd9ceb9.
    >
    > Reason for revert: Regressions https://chromeperf.appspot.com/group_report?rev=64356 https://crbug.com/1015749
    >
    > Original change's description:
    > > [regexp] Clone match info for match indices.
    > >
    > > The current behavior for generating match indices simply stashes a
    > > pointer to the match info and then constructs the indices lazily.
    > > However, it turns out the match info object used to create the result
    > > object is the regexp_last_match_info living on native context, and thus
    > > it can change between the creation of the result object and the generation
    > > of indices. This cl clones the match info which will be safer.
    > >
    > > Bug: v8:9548
    > > Change-Id: Ia6f26f88fbc22fd09671bf4c579d39a1510b552d
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864585
    > > Commit-Queue: Joshua Litt <joshualitt@chromium.org>
    > > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#64356}
    >
    > TBR=jgruber@chromium.org,joshualitt@chromium.org
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > Bug: v8:9548, chromium:1015749
    > Change-Id: I9c30b8fb459cf2aa89d920bf061614441250844d
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870236
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#64407}
    
    TBR=jgruber@chromium.org,joshualitt@chromium.org
    
    
    Bug: v8:9548, chromium:1015749
    Change-Id: I151511307e3d8752fdbde4b8247514031b141b08
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1879587Reviewed-by: 's avatarJoshua Litt <joshualitt@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Joshua Litt <joshualitt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64587}
    d4574d18
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...