• Clemens Backes's avatar
    Revert "[codegen] Remove redundant xorpd instructions" · 36f159b3
    Clemens Backes authored
    This reverts commit c4cf2ea4.
    
    Reason for revert: Seems to cause more regressions than improvement. Let's see what the perf bots say about the revert.
    
    Original change's description:
    > [codegen] Remove redundant xorpd instructions
    > 
    > It seems like they were originally added in https://crrev.com/23654026
    > (Sep 2013) to break dependences in the OOO pipeline. This code pattern
    > was then later copied for other instructions too
    > (https://crrev.com/1424333002).
    > The reason for the xorpd is not mentioned in the code though, and I
    > found no other compiler doing this. So maybe it's obsolete by now, and
    > only increases code size.
    > 
    > Let's remove them and see if we get any performance regressions.
    > 
    > R=​ahaas@chromium.org
    > CC=​yangguo@chromium.org
    > 
    > Change-Id: I0e6d65afa67f0ee286e5b0ba95c91092c5261c8f
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926427
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65077}
    
    TBR=yangguo@chromium.org,ahaas@chromium.org,clemensb@chromium.org
    
    Bug: chromium:1027876, chromium:1027449
    Change-Id: I533729722e294dbe567222b1c4084df6b864d2ff
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958053Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65388}
    36f159b3
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
assembler-arch.h Loading commit data...
assembler-inl.h Loading commit data...
assembler.cc Loading commit data...
assembler.h Loading commit data...
bailout-reason.cc Loading commit data...
bailout-reason.h Loading commit data...
callable.h Loading commit data...
code-comments.cc Loading commit data...
code-comments.h Loading commit data...
code-desc.cc Loading commit data...
code-desc.h Loading commit data...
code-factory.cc Loading commit data...
code-factory.h Loading commit data...
code-reference.cc Loading commit data...
code-reference.h Loading commit data...
code-stub-assembler.cc Loading commit data...
code-stub-assembler.h Loading commit data...
compilation-cache.cc Loading commit data...
compilation-cache.h Loading commit data...
compiler.cc Loading commit data...
compiler.h Loading commit data...
constant-pool.cc Loading commit data...
constant-pool.h Loading commit data...
constants-arch.h Loading commit data...
cpu-features.h Loading commit data...
external-reference-table.cc Loading commit data...
external-reference-table.h Loading commit data...
external-reference.cc Loading commit data...
external-reference.h Loading commit data...
flush-instruction-cache.cc Loading commit data...
flush-instruction-cache.h Loading commit data...
handler-table.cc Loading commit data...
handler-table.h Loading commit data...
interface-descriptors.cc Loading commit data...
interface-descriptors.h Loading commit data...
label.h Loading commit data...
machine-type.cc Loading commit data...
machine-type.h Loading commit data...
macro-assembler-inl.h Loading commit data...
macro-assembler.h Loading commit data...
optimized-compilation-info.cc Loading commit data...
optimized-compilation-info.h Loading commit data...
pending-optimization-table.cc Loading commit data...
pending-optimization-table.h Loading commit data...
register-arch.h Loading commit data...
register-configuration.cc Loading commit data...
register-configuration.h Loading commit data...
register.cc Loading commit data...
register.h Loading commit data...
reglist.h Loading commit data...
reloc-info.cc Loading commit data...
reloc-info.h Loading commit data...
safepoint-table.cc Loading commit data...
safepoint-table.h Loading commit data...
signature.h Loading commit data...
source-position-table.cc Loading commit data...
source-position-table.h Loading commit data...
source-position.cc Loading commit data...
source-position.h Loading commit data...
string-constants.cc Loading commit data...
string-constants.h Loading commit data...
tick-counter.cc Loading commit data...
tick-counter.h Loading commit data...
tnode.cc Loading commit data...
tnode.h Loading commit data...
turbo-assembler.cc Loading commit data...
turbo-assembler.h Loading commit data...
unoptimized-compilation-info.cc Loading commit data...
unoptimized-compilation-info.h Loading commit data...