• Toon Verwaest's avatar
    Reland^2 "[runtime] Amortize descriptor array growing for fast-mode prototypes" · d29b2f81
    Toon Verwaest authored
    Fix: check whether the map of the back pointer is the metamap rather than reading the map of the constructor-or-backpointer slot. If the slot contains a constructor, it's possible that the object transitions while the concurrent marker is reading the map (from which it's reading the instance type); and it's possible that the transitioned map isn't set up yet fully when we read the instance type. An acquire load for the constructor-or-backpointer map would also fix it by serializing stores, but is more expensive. Checking the metamap is faster.
    
    In case of false negatives (it is a map but we read the field before it was properly initialized) we'll simply mark too many descriptors in the worst case.
    
    Original change's description:
    > Revert "Reland "[runtime] Amortize descriptor array growing for fast-mode prototypes""
    > 
    > This reverts commit 71f9c117.
    > 
    > Reason for revert: Seems to cause several TSan flakes, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20concurrent%20marking/12926
    > 
    > Original change's description:
    > > Reland "[runtime] Amortize descriptor array growing for fast-mode prototypes"
    > > 
    > > This is a reland of 2de2d3dc
    > > 
    > > Original change's description:
    > > > [runtime] Amortize descriptor array growing for fast-mode prototypes
    > > >
    > > > This avoids an O(n^2) algorithm that creates an equal amount of garbage.
    > > > Even though the actual final descriptor array might be a little bigger,
    > > > it reduces peak memory usage by allocating less.
    > > >
    > > > Bug: b:148346655
    > > > Change-Id: I984159d36e9e0b37c19bc81afc90c94c9a9d168a
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135728
    > > > Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    > > > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#67031}
    > > 
    > > Bug: b:148346655, v8:10339
    > > Change-Id: I24436d8f49dc1fe527c4f6558db1abcba323b6f8
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139215
    > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > > Auto-Submit: Toon Verwaest <verwaest@chromium.org>
    > > Commit-Queue: Igor Sheludko <ishell@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#67475}
    > 
    > TBR=ulan@chromium.org,ishell@chromium.org,verwaest@chromium.org
    > 
    > Change-Id: I6fa02d0c89557eae33b792c1fe62c9c15eb0f7c7
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: b:148346655, v8:10339
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172749
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67478}
    
    TBR=ulan@chromium.org,clemensb@chromium.org,ishell@chromium.org,verwaest@chromium.org
    
    Change-Id: Ib86e039374e721919cd5b02495c252ee7af283bd
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b:148346655, v8:10339
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173359Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67495}
    d29b2f81
Name
Last commit
Last update
..
cppgc Loading commit data...
third-party Loading commit data...
OWNERS Loading commit data...
array-buffer-collector.cc Loading commit data...
array-buffer-collector.h Loading commit data...
array-buffer-sweeper.cc Loading commit data...
array-buffer-sweeper.h Loading commit data...
array-buffer-tracker-inl.h Loading commit data...
array-buffer-tracker.cc Loading commit data...
array-buffer-tracker.h Loading commit data...
barrier.h Loading commit data...
basic-memory-chunk.cc Loading commit data...
basic-memory-chunk.h Loading commit data...
code-stats.cc Loading commit data...
code-stats.h Loading commit data...
combined-heap.cc Loading commit data...
combined-heap.h Loading commit data...
concurrent-allocator-inl.h Loading commit data...
concurrent-allocator.h Loading commit data...
concurrent-marking.cc Loading commit data...
concurrent-marking.h Loading commit data...
embedder-tracing.cc Loading commit data...
embedder-tracing.h Loading commit data...
factory-base-inl.h Loading commit data...
factory-base.cc Loading commit data...
factory-base.h Loading commit data...
factory-inl.h Loading commit data...
factory.cc Loading commit data...
factory.h Loading commit data...
finalization-registry-cleanup-task.cc Loading commit data...
finalization-registry-cleanup-task.h Loading commit data...
gc-idle-time-handler.cc Loading commit data...
gc-idle-time-handler.h Loading commit data...
gc-tracer.cc Loading commit data...
gc-tracer.h Loading commit data...
heap-controller.cc Loading commit data...
heap-controller.h Loading commit data...
heap-inl.h Loading commit data...
heap-write-barrier-inl.h Loading commit data...
heap-write-barrier.h Loading commit data...
heap.cc Loading commit data...
heap.h Loading commit data...
incremental-marking-inl.h Loading commit data...
incremental-marking-job.cc Loading commit data...
incremental-marking-job.h Loading commit data...
incremental-marking.cc Loading commit data...
incremental-marking.h Loading commit data...
invalidated-slots-inl.h Loading commit data...
invalidated-slots.cc Loading commit data...
invalidated-slots.h Loading commit data...
item-parallel-job.cc Loading commit data...
item-parallel-job.h Loading commit data...
large-spaces.cc Loading commit data...
large-spaces.h Loading commit data...
list.h Loading commit data...
local-allocator-inl.h Loading commit data...
local-allocator.h Loading commit data...
local-heap.cc Loading commit data...
local-heap.h Loading commit data...
mark-compact-inl.h Loading commit data...
mark-compact.cc Loading commit data...
mark-compact.h Loading commit data...
marking-visitor-inl.h Loading commit data...
marking-visitor.h Loading commit data...
marking-worklist.cc Loading commit data...
marking-worklist.h Loading commit data...
marking.cc Loading commit data...
marking.h Loading commit data...
memory-measurement-inl.h Loading commit data...
memory-measurement.cc Loading commit data...
memory-measurement.h Loading commit data...
memory-reducer.cc Loading commit data...
memory-reducer.h Loading commit data...
object-stats.cc Loading commit data...
object-stats.h Loading commit data...
objects-visiting-inl.h Loading commit data...
objects-visiting.cc Loading commit data...
objects-visiting.h Loading commit data...
off-thread-factory-inl.h Loading commit data...
off-thread-factory.cc Loading commit data...
off-thread-factory.h Loading commit data...
off-thread-heap.cc Loading commit data...
off-thread-heap.h Loading commit data...
read-only-heap-inl.h Loading commit data...
read-only-heap.cc Loading commit data...
read-only-heap.h Loading commit data...
remembered-set.h Loading commit data...
safepoint.cc Loading commit data...
safepoint.h Loading commit data...
scavenge-job.cc Loading commit data...
scavenge-job.h Loading commit data...
scavenger-inl.h Loading commit data...
scavenger.cc Loading commit data...
scavenger.h Loading commit data...
setup-heap-internal.cc Loading commit data...
slot-set.cc Loading commit data...
slot-set.h Loading commit data...
spaces-inl.h Loading commit data...
spaces.cc Loading commit data...
spaces.h Loading commit data...
stress-marking-observer.cc Loading commit data...
stress-marking-observer.h Loading commit data...
stress-scavenge-observer.cc Loading commit data...
stress-scavenge-observer.h Loading commit data...
sweeper.cc Loading commit data...
sweeper.h Loading commit data...
worklist.h Loading commit data...