• Clemens Hammacher's avatar
    Revert "[wasm] Fix TODO and skip test on win32" · 6b6c2317
    Clemens Hammacher authored
    This reverts commit ad83fa92.
    
    Reason for revert: Crashes odroid: https://ci.chromium.org/p/v8/builders/ci/V8%20Arm%20-%20debug/11234
    
    Original change's description:
    > [wasm] Fix TODO and skip test on win32
    > 
    > In the {Fixed} variant, the {GrowingVsFixedModule} test first reserves
    > 1GB of memory, then allocates another 1GB to add it to the module as
    > code. This uses too much memory on win32, making the test fail.
    > Before this CL, the {NativeModule} only reserved 128kB upfront (in
    > contrast to the actual expectation of the test).
    > 
    > Since all other aspects of this test are already covered by other
    > tests, we just skip this test on win32.
    > This allows us to resolve the TODO.
    > 
    > Drive-by: Clean up the unittests status file a bit.
    > 
    > R=​mstarzinger@chromium.org
    > 
    > Bug: v8:9477
    > Change-Id: I575dd1a3f486e1805e0256e8ee6071246f2c24c4
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1816505
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#63921}
    
    TBR=mstarzinger@chromium.org,clemensh@chromium.org
    
    Change-Id: Ia9d9b9e311ff8b7524938aeb02543bf2c01bdd27
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:9477
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1815250Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63923}
    6b6c2317
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regress Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...