• Samuel Groß's avatar
    Only set DataView data_pointer after validation in constructor · 1ad8bd0d
    Samuel Groß authored
    Currently, when the input ArrayBuffer is detached during DataView
    construction, the code will create an invalid DataView object whose
    length, offset, and data_pointer are all incorrect. While this is
    currently ok as the DataView is never exposed to JavaScript in that
    case, it does cause issues as setting the data_pointer to a value
    outside of the V8 sandbox leads to a CHECK failure. This CL now ensures
    that the constructed DataView is always in a sane state to fix this.
    
    Bug: chromium:1354429
    Change-Id: I04260a5cf5547a420956d7a75e77f41408aa4f78
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3841931Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Commit-Queue: Samuel Groß <saelo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82619}
    1ad8bd0d
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...