• Clemens Hammacher's avatar
    Revert "Extract JSObject class from objects.cc" · d0a754e0
    Clemens Hammacher authored
    This reverts commit b8c821f4.
    
    Reason for revert: compile errors, e.g. https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20builder/39320
    
    Original change's description:
    > Extract JSObject class from objects.cc
    > 
    > I extracted following class member functions to js-objects.cc
    > * JSReceiver
    > * JSObject
    > * JSBoundFunction
    > * JSFunction
    > * JSGlobalObject
    > * JSDate
    > * JSMessageObject
    > 
    > Declaration of all above class are in js-objects.h.
    > 
    > I also moved AllocationSite::DigestTransitionFeedback used in JSObject::UpdateAllocationSite
    > and ShouldConvertToSlowElements used in JSObject and JSArray
    > 
    > This patch makes compile time of objects.cc from 17.6s to 14.1s on Z840 Linux.
    > And js-objects.cc takes 8.69s for compile.
    > 
    > Bug: v8:7629
    > Change-Id: I989f22363667445dd28d7f8c06c81ff79d6ed45f
    > Reviewed-on: https://chromium-review.googlesource.com/c/1447916
    > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Reviewed-by: Marja Hölttä <marja@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#59288}
    
    TBR=marja@chromium.org,mstarzinger@chromium.org,titzer@chromium.org,tikuta@chromium.org
    
    Change-Id: I18a8af8a7970f96b2ec3e56b2b1871b4f080ab01
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7629
    Reviewed-on: https://chromium-review.googlesource.com/c/1449635Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59289}
    d0a754e0
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...