• Georg Neis's avatar
    [compiler] Fix a (harmless) DCHECK failure · ce08dec0
    Georg Neis authored
    A frame state's outer frame state input can be kDeadValue. A DCHECK
    did not take that into account. In release builds there was no issue
    because we branch on the opcode anyways.
    
    While fixing this bug, I'm strengthening the FrameState class such that
    a FrameState node must have a kFrameState operator. I'm also
    - changing the result type of outer_frame_state() from FrameState to
      Node* since it may in fact not be a kFrameState;
    - removing has_outer_frame_state() because I find it unintuitive to
      have outer_frame_state() return non-NULL even when
      has_outer_frame_state() would return true.
    
    Bug: chromium:1224758
    Change-Id: I8ebed75c62e31f7eef71e2941fd18869d8a56af3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3001356Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75553}
    ce08dec0
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...