• kozyatinskiy's avatar
    [inspector] added check that context always survives inspected context · 2082afcf
    kozyatinskiy authored
    Inspected context is created in V8InspectorImpl::contextCreated method and destroyed in V8InspectorImpl::contextDestroyed.
    Both methods takes valid v8::Local<v8::Context> handle to the same context, it means that context is created before InspectedContext constructor and is always destroyed after InspectedContext destructor therefore context weak callback in inspected context should be never called.
    It's possible only if inspector client doesn't call contextDestroyed which is considered an error.
    
    Therefore CHECK(false) is added into context weak callback to be sure that v8::Context always survives inspected context.
    
    BUG=chromium:652548
    R=dgozman@chromium.org
    
    Review-Url: https://codereview.chromium.org/2413583002
    Cr-Commit-Position: refs/heads/master@{#40290}
    2082afcf
Name
Last commit
Last update
..
build Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
debugger-script.js Loading commit data...
debugger_script_externs.js Loading commit data...
injected-script-native.cc Loading commit data...
injected-script-native.h Loading commit data...
injected-script-source.js Loading commit data...
injected-script.cc Loading commit data...
injected-script.h Loading commit data...
injected_script_externs.js Loading commit data...
inspected-context.cc Loading commit data...
inspected-context.h Loading commit data...
inspector.gyp Loading commit data...
inspector.gypi Loading commit data...
inspector_protocol_config.json Loading commit data...
java-script-call-frame.cc Loading commit data...
java-script-call-frame.h Loading commit data...
js_protocol-1.2.json Loading commit data...
js_protocol.json Loading commit data...
protocol-platform.h Loading commit data...
remote-object-id.cc Loading commit data...
remote-object-id.h Loading commit data...
script-breakpoint.h Loading commit data...
search-util.cc Loading commit data...
search-util.h Loading commit data...
string-16.cc Loading commit data...
string-16.h Loading commit data...
string-util.cc Loading commit data...
string-util.h Loading commit data...
v8-console-agent-impl.cc Loading commit data...
v8-console-agent-impl.h Loading commit data...
v8-console-message.cc Loading commit data...
v8-console-message.h Loading commit data...
v8-console.cc Loading commit data...
v8-console.h Loading commit data...
v8-debugger-agent-impl.cc Loading commit data...
v8-debugger-agent-impl.h Loading commit data...
v8-debugger-script.cc Loading commit data...
v8-debugger-script.h Loading commit data...
v8-debugger.cc Loading commit data...
v8-debugger.h Loading commit data...
v8-function-call.cc Loading commit data...
v8-function-call.h Loading commit data...
v8-heap-profiler-agent-impl.cc Loading commit data...
v8-heap-profiler-agent-impl.h Loading commit data...
v8-injected-script-host.cc Loading commit data...
v8-injected-script-host.h Loading commit data...
v8-inspector-impl.cc Loading commit data...
v8-inspector-impl.h Loading commit data...
v8-inspector-session-impl.cc Loading commit data...
v8-inspector-session-impl.h Loading commit data...
v8-internal-value-type.cc Loading commit data...
v8-internal-value-type.h Loading commit data...
v8-profiler-agent-impl.cc Loading commit data...
v8-profiler-agent-impl.h Loading commit data...
v8-regex.cc Loading commit data...
v8-regex.h Loading commit data...
v8-runtime-agent-impl.cc Loading commit data...
v8-runtime-agent-impl.h Loading commit data...
v8-schema-agent-impl.cc Loading commit data...
v8-schema-agent-impl.h Loading commit data...
v8-stack-trace-impl.cc Loading commit data...
v8-stack-trace-impl.h Loading commit data...
v8-value-copier.cc Loading commit data...
v8-value-copier.h Loading commit data...