• Peter Kasting's avatar
    Fix some instances of -Wunreachable-code-aggressive. · ca596361
    Peter Kasting authored
    These need some consideration.  Clang apparently considers V8_UNLIKELY
    to mean "always false", which seems questionable to me (possibly a
    bug?).  That said, removing it in the cases here doesn't seem likely to
    cause problems -- the logging instance seems fine, and the other used to
    not have the macro and gained it in a commit that seemed to have nothing
    to do with performance.
    
    The trampoline register change is safe, but perhaps V8 will support an
    architecture in the future which needs this conditional?
    
    I'd leave these as-is, but it also seems a shame not to enable
    -Wunreachable-code-aggressive just because of these...
    
    Bug: chromium:1066980
    Change-Id: Ib819298cecba082666c26fa7010009f8e9441bf8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994805
    Auto-Submit: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Hannes Payer <hpayer@chromium.org>
    Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75681}
    ca596361
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...