• Ng Zhi An's avatar
    [wasm-simd][liftoff][arm64] Check offset fits in str immediate · c92e74fa
    Ng Zhi An authored
    When filling stack slots, the start offset can be too large to fit into
    the immediate of a str instruction (which is used to handle remainders
    after stp). For example, a function with 32 i64 params will require 256
    bytes reserved for the params, so the offset starts at 256 + 16
    (instance) = 272. This does not fit into a int9, so we hit an
    UNREACHABLE case when emitting str.
    
    The fix here checks that start can fit in an unscaled immediate, and if
    it doesn't fallback to the general case. We could use the Str
    from macro-asesmbler, but that uses another instruction, so we are not
    saving anything.
    
    A check for IsImmLSUnscaled(-start-12) is sufficient because 12 is the
    largest possible value for remainder. So if -start-12 fits, everything
    else will fit.
    
    Bug: v8:10645
    Change-Id: I1c415499ada3a807d5f3889f091150bfefdf471d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2267369
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68594}
    c92e74fa
Name
Last commit
Last update
..
OWNERS Loading commit data...
test-c-wasm-entry.cc Loading commit data...
test-compilation-cache.cc Loading commit data...
test-gc.cc Loading commit data...
test-grow-memory.cc Loading commit data...
test-jump-table-assembler.cc Loading commit data...
test-liftoff-inspection.cc Loading commit data...
test-run-wasm-64.cc Loading commit data...
test-run-wasm-asmjs.cc Loading commit data...
test-run-wasm-atomics.cc Loading commit data...
test-run-wasm-atomics64.cc Loading commit data...
test-run-wasm-bulk-memory.cc Loading commit data...
test-run-wasm-exceptions.cc Loading commit data...
test-run-wasm-interpreter.cc Loading commit data...
test-run-wasm-js.cc Loading commit data...
test-run-wasm-module.cc Loading commit data...
test-run-wasm-sign-extension.cc Loading commit data...
test-run-wasm-simd-liftoff.cc Loading commit data...
test-run-wasm-simd-scalar-lowering.cc Loading commit data...
test-run-wasm-simd.cc Loading commit data...
test-run-wasm.cc Loading commit data...
test-streaming-compilation.cc Loading commit data...
test-wasm-breakpoints.cc Loading commit data...
test-wasm-codegen.cc Loading commit data...
test-wasm-debug-evaluate.cc Loading commit data...
test-wasm-import-wrapper-cache.cc Loading commit data...
test-wasm-serialization.cc Loading commit data...
test-wasm-shared-engine.cc Loading commit data...
test-wasm-stack.cc Loading commit data...
test-wasm-trap-position.cc Loading commit data...
wasm-atomics-utils.h Loading commit data...
wasm-run-utils.cc Loading commit data...
wasm-run-utils.h Loading commit data...